feat: update apex-jorje-lsp with setTrace handler #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to make the update of setTrace handler in effect, so that there will not be UnsupportedOperationException from Apex LS when setTrace is triggered in client side.
What issues does this PR fix or reference?
@W-14352262@
Functionality Before
There are UnsupportedOperationException from the output of Apex Language Server every time users change VS Code workspace configurations. The default implementation of setTrace in Apex Language Server is only to send the exception even if the operation of setTrace is done by lsp4j.
Functionality After
setTrace function is updated so that there will not be any UnsupportedOperationException in output if the trace level is valid ("off", "messages" and "verbose").