feat: validate CLI installation and version during activation of CLI Integration extension #5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if CLI is not installed
…is unsupported + cleanup code
daphne-sfdc
commented
Oct 26, 2023
daphne-sfdc
commented
Oct 26, 2023
daphne-sfdc
commented
Oct 26, 2023
daphne-sfdc
requested review from
RitamAgrawal and
CristiCanizales
and removed request for
RitamAgrawal
CristiCanizales
requested changes
Oct 27, 2023
gbockus-sf
reviewed
Oct 31, 2023
gbockus-sf
reviewed
Oct 31, 2023
gbockus-sf
reviewed
Oct 31, 2023
gbockus-sf
reviewed
Oct 31, 2023
gbockus-sf
reviewed
Oct 31, 2023
gbockus-sf
reviewed
Oct 31, 2023
gbockus-sf
reviewed
Oct 31, 2023
gbockus-sf
reviewed
Oct 31, 2023
Co-authored-by: peternhale <peternhale@users.noreply.github.com>
…tion.ts Co-authored-by: Cristina Cañizales <113132642+CristiCanizales@users.noreply.github.com>
diyer
reviewed
Dec 19, 2023
peternhale
requested changes
Dec 19, 2023
peternhale
requested changes
Dec 21, 2023
diyer
reviewed
Dec 21, 2023
CristiCanizales
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
All good from QA perspective both in mac and windows! ✅
After the text updates I'd say 
Nice work Daphne! 🥳
QA doc here
peternhale
requested changes
Dec 28, 2023
Co-authored-by: peternhale <peternhale@users.noreply.github.com>
peternhale
approved these changes
Dec 28, 2023
|
The text for the message recommending the move to SF from SFDX is here. |
daphne-sfdc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes new functionality to check whether a supported CLI version is installed on the user's computer. There are 4 main cases that are being caught: (1) CLI not installed (2) Outdated version of SFDX CLI that is incompatible with our extensions (3) Only SF v1 is installed (4) Both SFDX v7 and SF v2 are installed. In each of those 4 cases, the CLI Integration extension will not activate, and the user will not be able to see SFDX commands in the command palette. The user will receive an error notification about the unsupported/missing CLI when the activation of the CLI Integration extension fails.
What issues does this PR fix or reference?
@W-14196710@
Functionality Before
As a result of the recent switch from SFDX -> SF-style variables to get rid of warnings in the Output tab, users with a CLI version below SFDX v7.193.2 are no longer able to use the extensions because older CLI versions do not support SF-style variables. The extensions will activate, but the older version is caught at runtime.
Functionality After
If the user does not have CLI installed on their computer or their installed CLI version is no longer supported, they will get an error notification when they first create/open a Salesforce Project and the CLI Integration extension will not activate. Based on the case, one of these 4 error messages will pop up:
