fix: call language client stop during deactivation #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbockus-sf
reviewed
Nov 7, 2023
| @@ -284,6 +284,7 @@ async function registerTestView(): Promise<vscode.Disposable> { | |||
| } | |||
|
|
|||
| export async function deactivate() { | |||
| await languageClient?.stop(); | |||
There was a problem hiding this comment.
sweet. We already have a unit test suite for this class. Mind adding a unit test for the deactivate function? I'll QE in the mean time.
gbockus-sf
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Thanks for the quick fix!
QE passed.
Test Cases
- Verify when run via a vsix the Apex LSP exits when VSCode is shut down via the X ✅
- Verify when run via a vsix the Apex LSP exits when VSCode is shut down via quit Visual Studio Code ✅
- Verify when run via a vsix the Apex LSP exits when VSCode is shut down when running in dev mode ✅
gbockus-sf
reviewed
Nov 9, 2023
gbockus-sf
reviewed
Nov 9, 2023
gbockus-sf
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of language servers being orphaned.
This change adds a call to the language client stop function during the apex extension deactivate call.
@W-14446753@