Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ext deps to enable faster activation #5250

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

gbockus-sf
Copy link
Contributor

@gbockus-sf gbockus-sf commented Nov 28, 2023

What does this PR do?

Update the extensions to have extDeps when not already present.
core <- apex, lwc, lighting, soql
apex <- apex-debugger, apex-replay-debugger

One concern is this makes uninstalling individual extensions have an order. You can not uninstall an ext until all ext with deps have been uninstalled. Not an issue when using extension packs.

What issues does this PR fix or reference?

@W-14418821@

Functionality Before

four extension attempted to activate at the same time

Functionality After

core activates first, then apex, lwc, lightning, and soql, then the debugger after apex.

Tested vsix files on windows to verify all extensions load

Screenshot 2023-11-28 at 12 49 37 AM

@gbockus-sf gbockus-sf requested a review from a team as a code owner November 28, 2023 06:19
@gbockus-sf gbockus-sf merged commit 37df5c2 into develop Nov 28, 2023
15 checks passed
@gbockus-sf gbockus-sf deleted the gbockus/W-14418821-add-extension-deps branch November 28, 2023 17:28
@CristiCanizales CristiCanizales linked an issue Dec 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incredibly Slow Startup
2 participants