chore: core API to access the sfdx project namespace. #5253
Conversation
gbockus-sf
changed the title
| public async getSfdxNamespace(): Promise<string | undefined> { | ||
| const namespace = await SfdxProjectConfig.getValue('namespace'); | ||
| return typeof namespace === 'string' ? namespace : undefined; | ||
| } |
There was a problem hiding this comment.
Hey Flora. Sorry for the delay. Rather then overloading the workspaceContext with sfdxConfig info, how about we add SfdxProjectConfig as a new exported api? The SfdxConfig seems like an obvious addition to the core extension API. Basically just add SfdxProjectConfig to
Thoughts?
There was a problem hiding this comment.
@gbockus-sf Yeah, I've considered adding another exported API vs overloading the workspaceContext. The sfdx namespace exists in the sfdx-project.json file, which is located in the workspace, so I thought it made sense to include it as part of the workspaceContext. I'm open to moving it to a new API if you have a strong preference.
There was a problem hiding this comment.
Thanks @floralan! Yeah Let's go ahead and make that API update. It will ensure we have access to any configuration without having to update the workspace context 👍
What does this PR do?
This PR adds the
getSfdxNamespacefunction to the core API so that we can utilize it in E4D. PR in E4D that uses this function: https://github.com/forcedotcom/salesforcedx-vscode-einstein-gpt/pull/222What issues does this PR fix or reference?
@W-14559660@
Functionality Before
Can't get sfdx project namespace from the core extension API
Functionality After
Available function to get sfdx project namespace.