Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: org delete commands to sf style #5294

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

CristiCanizales
Copy link
Contributor

@CristiCanizales CristiCanizales commented Dec 26, 2023

What does this PR do?

  • Updates org delete commands and flags to SF style in order to get rid of cli warnings

What issues does this PR fix or reference?

@W-14700710@

Functionality Before

  • org delete commands in sfdx style

Functionality After

  • org delete commands in sf style

@CristiCanizales CristiCanizales self-assigned this Dec 26, 2023
@CristiCanizales CristiCanizales changed the title chore: org delete commands to sf style fix: org delete commands to sf style Dec 26, 2023
@CristiCanizales CristiCanizales marked this pull request as ready for review December 26, 2023 15:22
@CristiCanizales CristiCanizales requested a review from a team as a code owner December 26, 2023 15:22
.withArg('--noprompt')
.withLogName('force_org_delete_default');
.withDescription(nls.localize('org_delete_default_text'))
.withArg('org:scratch')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.withArg('org:scratch')
.withArg('org:delete:scratch')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how tests were passing with this typo... 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests disabled.

Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

Commands Tested:

  1. SFDX: Delete Default Org ✅
  2. SFDX: Delete Org ✅

@CristiCanizales CristiCanizales merged commit ecc4b1f into develop Jan 3, 2024
12 checks passed
@CristiCanizales CristiCanizales deleted the cristi/w-14700710/org-delete-to-sf branch January 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants