Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forceTaskStop and forceOpenDocumentation to sf #5297

Merged
merged 5 commits into from
Jan 8, 2024
Merged

fix: forceTaskStop and forceOpenDocumentation to sf #5297

merged 5 commits into from
Jan 8, 2024

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Updates cancel command and open documentation command to SF style in order to get rid of cli warnings

What issues does this PR fix or reference?

@W-14720671@

Functionality Before

  • cancel command and open documentation command in sfdx style

Functionality After

  • cancel command and open documentation command in sf style

@CristiCanizales CristiCanizales self-assigned this Dec 27, 2023
@CristiCanizales CristiCanizales marked this pull request as ready for review December 27, 2023 05:13
@CristiCanizales CristiCanizales requested a review from a team as a code owner December 27, 2023 05:13
daphne-sfdc
daphne-sfdc approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

Commands tested:

  1. SFDX: Open Documentation ✅
  2. SFDX: Cancel Active Command ✅ (NOTE: command didn't work before, still doesn't work, but this PR did not break the functionality)

@daphne-sfdc daphne-sfdc merged commit 2d79485 into develop Jan 8, 2024
12 checks passed
@daphne-sfdc daphne-sfdc deleted the cristi/w-14720671 branch January 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternhale peternhale peternhale approved these changes

@daphne-sfdc daphne-sfdc daphne-sfdc approved these changes

@klewis-sfdc klewis-sfdc Awaiting requested review from klewis-sfdc klewis-sfdc is a code owner automatically assigned from forcedotcom/ide-experience

@mingxuanzhangsfdx mingxuanzhangsfdx Awaiting requested review from mingxuanzhangsfdx

Assignees

@CristiCanizales CristiCanizales

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CristiCanizales @peternhale @daphne-sfdc