Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create commands from sfdx to sf style #5303

Merged
merged 13 commits into from
Jan 5, 2024

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Updates create commands and flags to SF style in order to get rid of cli warnings

What issues does this PR fix or reference?

@W-14720804@

Functionality Before

  • create commands in sfdx style

Functionality After

  • create commands in sf style

@CristiCanizales CristiCanizales self-assigned this Dec 29, 2023
@CristiCanizales CristiCanizales marked this pull request as ready for review December 29, 2023 17:16
@CristiCanizales CristiCanizales requested a review from a team as a code owner December 29, 2023 17:16
lightningGenerateEvent,
lightningGenerateInterface,
lightningGenerateLwc,
forceLightningLwcTestCreate,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in alphabetical order

Comment on lines -47 to +49
it('Should create Apex Class', async () => {
it('Should generate Apex Trigger', async () => {
// arrange
const outputPath = 'force-app/main/default/classes';
const outputPath = 'force-app/main/default/triggers';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find 🙂

Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

These were the commands that were modified and tested in this PR:

  1. SFDX: Create Apex Class ✅
  2. SFDX: Create Unit Test Class ✅
  3. SFDX: Create Aura App ✅
  4. SFDX: Create Aura Component ✅
  5. SFDX: Create Aura Event ✅
  6. SFDX: Create Aura Interface ✅
  7. SFDX: Create Lightning Web Component ✅
  8. SFDX: Create Lightning Web Component Test ✅
  9. SFDX: Create Visualforce Component ✅
  10. SFDX: Create Visualforce Page ✅
  11. SFDX: Create Sample Analytics Template ✅

@CristiCanizales CristiCanizales merged commit 65531d9 into develop Jan 5, 2024
12 checks passed
@CristiCanizales CristiCanizales deleted the cristi/w-14720804/create-commands branch January 5, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants