fix: add sf log level to current runtime #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-15062541@
mingxuanzhangsfdx
approved these changes
Feb 21, 2024
| @@ -109,7 +109,7 @@ export class SfdxCoreSettings { | |||
| public getSfLogLevel(): string { | |||
| return this.getConfigValue( | |||
| ENV_SF_LOG_LEVEL, | |||
| process.env.SF_LOG_LEVEL ?? '' | |||
| process.env.SF_LOG_LEVEL ?? 'debug' | |||
There was a problem hiding this comment.
Given that the above default is fatal, why don't you keep it here same?
mingxuanzhangsfdx
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables debug logging for libraries that consume the env var
SF_LOG_LEVELby pushing the extension setting into the current process.env.One should expect commands such as deploy to org or retrieve from org show show debug log entries to the sf log files, when the log level is set to the correct level used by the libraries.
Added validation of ext setting to ensure the setting values match those provided by core logging config.
@W-15062541@