Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add No response bot to manage inactive issues. Update version of pret… #550

Merged
merged 3 commits into from Aug 13, 2018

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Aug 9, 2018

…tier to enable yaml formatting.

@W-5315918@

What does this PR do?

Adds a configuration file for No Response bot (https://github.com/probot/no-response) usage on the repo.
Also updates prettier to the latest version and enables yaml file formatting.

What issues does this PR fix or reference?

@W-5315918@

@@ -0,0 +1,10 @@
# Configuration for probot-no-response - https://github.com/probot/no-response

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config means the bot will look at issues with more information required label on it and if it's been inactive for 7 days it will close it with the comment listed here.

@lcampos lcampos requested review from vazexqi and ntotten August 9, 2018 23:47
@vazexqi
Copy link
Contributor

vazexqi commented Aug 9, 2018

Is the VS Code bot from Microsoft available? I recall that one being smarter in not just closing things with more-information-required but also anything that just didn't have any reasonable activity.

.travis.yml Outdated
@@ -3,7 +3,7 @@ language: node_js
sudo: required

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we removed Travis completely. How come we still have a .travis.yml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but I can remove it as part of this PR.

@lcampos
Copy link
Contributor Author

lcampos commented Aug 10, 2018

They use several bots but based on their config I think they might have their own bots. The closest one I found was this and another one called Stale (https://probot.github.io/apps/stale/). Stale looks at both issues & PRs and closes them based on certain configurable params. I thought it was a bit too much based on how many open issues we have that are waiting on further info from the author.

@vazexqi
Copy link
Contributor

vazexqi commented Aug 13, 2018

OK. Let's go with this one first and see if we need to change. I don't have any better recommendations and we can always switch later.

@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #550 into develop will decrease coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #550      +/-   ##
===========================================
- Coverage    74.41%   73.57%   -0.85%     
===========================================
  Files          149      149              
  Lines         5832     5832              
  Branches       917      917              
===========================================
- Hits          4340     4291      -49     
- Misses        1262     1315      +53     
+ Partials       230      226       -4
Impacted Files Coverage Δ
...kages/salesforcedx-vscode-apex/src/requirements.ts 27.5% <0%> (-47.5%) ⬇️
...ges/salesforcedx-vscode-apex/src/languageServer.ts 40.74% <0%> (-27.78%) ⬇️
...pex-replay-debugger/src/adapter/apexReplayDebug.ts 83.4% <0%> (-4.04%) ⬇️
...orcedx-apex-replay-debugger/src/core/logContext.ts 65.74% <0%> (-2.77%) ⬇️
...lay-debugger/src/states/variableAssignmentState.ts 89.15% <0%> (-1.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5bddf...5720ebd. Read the comment docs.

@lcampos lcampos merged commit 6f0ad8d into develop Aug 13, 2018
@lcampos lcampos deleted the lcampos/inactive-issue-bot branch August 13, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants