fix: report right command execution status #5500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diyer
reviewed
Mar 12, 2024
| @@ -444,9 +443,9 @@ export class IsvDebugBootstrapExecutor extends SfdxCommandletExecutor<{}> { | |||
| ) { | |||
| channelService.streamCommandOutput(execution); | |||
| channelService.showChannelOutput(); | |||
| notificationService.reportExecutionError( | |||
There was a problem hiding this comment.
can you explain this change please :)
There was a problem hiding this comment.
so the function we were calling before was 'reportExecutionError', which as the name says is used for reporting errors. I just changed it to the other function that is used to report general command execution
There was a problem hiding this comment.
got it. so now we will get a notification on command execution status?
daphne-sfdc
approved these changes
Mar 14, 2024
peternhale
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Functionality Before
Functionality After
[skip-validate-pr]