Update format configuration for prettier #561
Conversation
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Adding this config file so we can leverage the same options on the scripts & code editors
|
I'm thinking I'll have to make this change in release branch as well to avoid any weird merges with the publishing process. |
Codecov Report
@@ Coverage Diff @@
## develop #561 +/- ##
========================================
Coverage 73.37% 73.37%
========================================
Files 149 149
Lines 5837 5837
Branches 917 917
========================================
Hits 4283 4283
Misses 1328 1328
Partials 226 226Continue to review full report at Codecov.
|
| @@ -7,7 +7,7 @@ | |||
| "husky": "0.14.3", | |||
| "istanbul": "1.1.0-alpha.1", | |||
| "lerna": "2.4.0", | |||
| "prettier": "1.14.2", | |||
| "prettier": "1.6.0", | |||
There was a problem hiding this comment.
@lcampos - How come we had to downgrade prettier?
I thought you wanted the newer version to be able to use it with yaml?
There was a problem hiding this comment.
NVM. I saw your explanation on Slack:
@nchen it looks like the newest version of prettier (1.14.2) does not wrap lines the same way version 1.6.0 used to. I'll revert to the previous version (1.6.0) since we want to keep the current format of our files
@lcampos - I think you're right. You want to do this in both the release and also the develop branch so that everything is in sync. |
What does this PR do?
Updates the version of prettier to 1.6.0 to address reformat diffs.
What issues does this PR fix or reference?