chore: update screenshots folder name to match actions/upload-artifact@v4 #5640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the issue where screenshots were not being produced for E2E test failures. The issue is happening as a result of the breaking change in actions/upload-artifact@v4.
What issues does this PR fix or reference?
@W-15960945@
Functionality Before
Only one job in a failing E2E test run produces screenshots; the other jobs produce error messages in the upload artifact step with the error message
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run.https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/9477771277
Functionality After
All jobs in a failing E2E test run produce screenshots, in separate folders for each job.
https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/9486595338