Swap LWC with LWC-next #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for Winter '19. @W-5487489@
vazexqi
commented
Oct 4, 2018
| @@ -26,7 +26,7 @@ | |||
| "@salesforce/salesforcedx-utils-vscode": "43.19.0", | |||
| "ajv": "^6.1.1", | |||
| "eslint": "4.16.0", | |||
| "lwc-language-server": "1.5.1", | |||
| "lwc-language-server": "1.6.7", | |||
There was a problem hiding this comment.
@rsalvador - This should be the main change from your side.
vazexqi
commented
Oct 4, 2018
| @@ -80,7 +80,7 @@ class ForceLightningLwcCreateExecutor extends (SfdxCommandletExecutor as { | |||
| return new SfdxCommandBuilder() | |||
| .withDescription(nls.localize('force_lightning_lwc_create_text')) | |||
| .withArg('force:lightning:component:create') | |||
| .withFlag('--type', 'web') | |||
| .withFlag('--type', 'lwc') | |||
There was a problem hiding this comment.
This is the new flag for the CLI. This naming change aligns better with our messaging.
rsalvador
approved these changes
Oct 4, 2018
Codecov Report
@@ Coverage Diff @@
## develop #660 +/- ##
========================================
Coverage 74.83% 74.83%
========================================
Files 158 158
Lines 6405 6405
Branches 1001 1001
========================================
Hits 4793 4793
Misses 1357 1357
Partials 255 255Continue to review full report at Codecov.
|
This was referenced Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the latest version of LWC for Winter '19.
What issues does this PR fix or reference?
@W-5487489@