Enable Checkpoints by default #664
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -218,7 +218,7 @@ | |
| "properties": { | ||
| "salesforcedx-vscode-apex-replay-debugger-checkpoints.enabled": { | ||
|
There was a problem hiding this comment. Won't it be better to just remove this whole properties? That's what we did before after we are ready to GA something that was guarded. Or, do you
There was a problem hiding this comment. @vazexqi we (the team) had talked about this in standup earlier this week. We decided that leaving the flag in, for the moment, was the way we wanted to handle this right now. We are ultimately going to remove this but with the current timeline this was the safest change. |
||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "%replay-debugger_checkpoints_enabled%" | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove this? It seems benign and safer to leave this in and just use the commented out technique up there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vazexqi In https://github.com/forcedotcom/salesforcedx-vscode/pull/559/files, I removed this line because I thought that the test script would run all scripts in the package.json that began with "test:*", and I wanted to prevent the system-tests from being run. However, I see that in the .appveyor.yml, line 43 runs
test:without-system-testsso I'm a bit confused. If the autobuild is already running the script that ignores system tests, then is it thenpm run coverage:system-teststhat invokes the system tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure if comments in a package.json are a thing. From what I've read there's no comment syntax for the entries that isn't hacky. Removal and re-addition seem like the way to go here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vazexqi things are ready but I'm not going to submit until you say so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allileong
Yes, it is
coverage:system-teststhat invokes the system tests. This can be seen at https://github.com/forcedotcom/salesforcedx-vscode/blob/develop/package.json#L37 where it will invoke the system tests.@JimSuplizio
In the interest of time, let's proceed with what we have and restore it back in "W-5507653 - User Story - Re-enable UI system-tests in AppVeyor".