Merge pull request #818 from forcedotcom/ew/logger-loop

Fix logging loop
forcedotcom · Apr 21, 2023 · 28f564e · 28f564e
2 parents c17a69f + a9f9a47
commit 28f564e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/logger.ts b/src/logger.ts
@@ -762,8 +762,10 @@ export class Logger {
    */
   public fatal(...args: unknown[]): Logger {
     // always show fatal to stderr
-    // eslint-disable-next-line no-console
-    console.error(...args);
+    // IMPORTANT:
+    // Do not use console.error() here, if fatal() is called from the uncaughtException handler, it
+    // will be re-thrown and caught again by the uncaughtException handler, causing an infinite loop.
+    console.log(...args); // eslint-disable-line no-console
     this.bunyan.fatal(this.applyFilters(LoggerLevel.FATAL, ...args));
     return this;
   }

diff --git a/test/unit/loggerTest.ts b/test/unit/loggerTest.ts
@@ -280,13 +280,7 @@ describe('Logger', () => {
 
     it('should apply for log level: error', () => runTest(['error', 50]));
 
-    it('should apply for log level: fatal', async () => {
-      // logger.fatal() necessarily writes to stderr so stub it here
-      $$.SANDBOX.stub(process.stderr, 'write');
-      await runTest(['fatal', 60]);
-      // @ts-expect-error: called is a sinon spy property
-      expect(process.stderr.write['called']).to.be.true;
-    });
+    it('should apply for log level: fatal', () => runTest(['fatal', 60]));
   });
 
   describe('addField', () => {