@W-11111352@: SARIF and Table format now properly format output in the event of SFGE errors. #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e event of SFGE errors.
rmohan20
reviewed
May 16, 2022
| "sourceColumn": 8, | ||
| "sourceType": "BearController", | ||
| "sourceMethodName": "getAllBears", | ||
| "sinkFileName": null, |
There was a problem hiding this comment.
Would empty strings be safer than nulls?
There was a problem hiding this comment.
Probably. Stand by for that.
rmohan20
reviewed
May 16, 2022
| "Source Location": `${relativeFile}:${violation.sourceLine}`, | ||
| "Source Line": violation.sourceLine, | ||
| "Source Column": violation.sourceColumn, | ||
| "Sink Location": null, |
There was a problem hiding this comment.
Same with these nulls as well.
There was a problem hiding this comment.
I think we want the line and column to still be null, since those are supposed to be numbers. But the location can be an empty string, I believe.
rmohan20
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
tableandsarifoutput formats to not explode when a path-based violation lacks a sink vertexsarif-based error case