feat!: core7 #564
Merged
feat!: core7 #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: core7, sdr11, jsforce-node
| throw SfError.create({ | ||
| message: e.message, | ||
| name: e.name, | ||
| data: e.errors.map((err) => err.message), |
There was a problem hiding this comment.
the previous code was saving the whole iso-git errors array but I think this is ok, those are still accessible in e.cause.errors in caller code.
There was a problem hiding this comment.
yeah, cause is meant to cover that. data is typed now as AnyJson and TS didn't like Error[] (because error is a class, has various methods, etc).
Which is probably an improvement.
cristiand391
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
core7, etc.
node16 module/moduleResolution
one "actual" change because of typing changes in SfError https://github.com/forcedotcom/source-tracking/pull/564/files#diff-4774812bffb4d5f23a015e0d489b38f62335c3c30ca3d2b6c07760300b346d86R282
What issues does this PR fix or reference?
@W-13565856@