Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured output options to determine what code runs #50

Open
forceedge01 opened this issue Feb 10, 2020 · 6 comments
Open

Configured output options to determine what code runs #50

forceedge01 opened this issue Feb 10, 2020 · 6 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@forceedge01
Copy link
Owner

Even though at this point we can control what to output as part of the failure summary, the code is executed regardless. In situations such as testing the API, a screenshot doesn't serve much of a purpose. While there are ways to not show the screenshot even if the output is not controllable individually by the context file (controlled by the extension definition), the code executed produces a 500 error because the configuration elements are different.

For example when testing an API, there is no page to visit - this logic should run only if a screenshot is asked for.

@forceedge01
Copy link
Owner Author

forceedge01 commented Feb 10, 2020

Move logic into files that can check the output options. Don't run logic that isn't asked for. The options should be overridable by the context themselves.

@forceedge01
Copy link
Owner Author

At present, the ->getPage() call throws an exception when working with requests on API.

@forceedge01 forceedge01 added the enhancement New feature or request label Feb 10, 2020
@forceedge01 forceedge01 added the bug Something isn't working label Mar 9, 2020
@forceedge01
Copy link
Owner Author

Partially implemented for screenshot and debug bar selectors.

@forceedge01
Copy link
Owner Author

forceedge01 commented Mar 10, 2020

To make this safe, surround getUrl and getStatusCode calls as well with getOption call.
add debugBarSelectors to output controlled options as well.

output:
screenshot: false
url: false
status: false
debugBarSelectors: false

@forceedge01
Copy link
Owner Author

add trackJs to the list.

@forceedge01
Copy link
Owner Author

Replace feature output with scenario output? Does rerun output help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant