-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configured output options to determine what code runs #50
Comments
Move logic into files that can check the output options. Don't run logic that isn't asked for. The options should be overridable by the context themselves. |
At present, the ->getPage() call throws an exception when working with requests on API. |
Partially implemented for screenshot and debug bar selectors. |
To make this safe, surround getUrl and getStatusCode calls as well with getOption call. output: |
add trackJs to the list. |
Replace feature output with scenario output? Does rerun output help? |
Even though at this point we can control what to output as part of the failure summary, the code is executed regardless. In situations such as testing the API, a screenshot doesn't serve much of a purpose. While there are ways to not show the screenshot even if the output is not controllable individually by the context file (controlled by the extension definition), the code executed produces a 500 error because the configuration elements are different.
For example when testing an API, there is no page to visit - this logic should run only if a screenshot is asked for.
The text was updated successfully, but these errors were encountered: