-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres 10 Sequence support #225
Comments
(Sorry for the noise, wrong email) Just throwing my patch for this issue over the wall as I needed a quick fix for work. Still needs a test update, feel free to pick it up or I'll do that when I get more time. :) |
I can confirm that olasd's patch works. |
Anyone want to open a PR and I can merge that into the develop branch? |
Hi, I opened the PR with olasd's code and also added the changes to support alter sequence data_type . Would be interesting if someone else confirmed that this PR works. If you still need adjustments tell me that I ll be glad to make the changes |
Has this been merged to master yet? |
Not yet |
Am I missing something here or is the real issue "apgdiff does not support PostgreSQL 10"? In other words is there a workaround, like ignoring sequences? |
@jflambert, @iyobo Are you able to build apgdiff and test the changes made in #228 Should be fixed with the changes |
@olasd I am also facing same issue ..How can I get jar for this issue 225. |
The jar mentionend in #241 contains the fix |
Thank you very much @valoricDe. Its working now. |
Dumps created with Postgres 10 that contain Sequences crash apgdiff.
Postgres 9.x dumps sequences like this:
Postgres 10 adds a "AS integer"
This is refused by apgdiff
The text was updated successfully, but these errors were encountered: