Fix bug on MainActivity onDestro. App crashes when closing the app with back button #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdocr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Before closing the app (for example when using the back button) the Main Activity (from
onDestroy()) clears out lingering resources like the audio service. The webViewBridge wasn't checking to make sure the service exists before requesting the context to stop it causing the crash.Killing the app directly from multitasking doesn't seem to execute the onDestroy() and this was a subtle problem that has been flying under the radar until now.
Related Tickets & Documents
Fixes #106
[optional] What gif best describes this PR or how it makes you feel?