Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Pull out HTML, CSS and JavaScript scripts from content.js into separate assets #31

Open
nickytonline opened this issue Aug 12, 2020 · 2 comments
Labels
DX Developer experience enhancement New feature or request type: discussion topics open for discussion

Comments

@nickytonline
Copy link
Contributor

Currently JS, CSS and HTML are all built via JavaScript in content.js. To be able to maintain the browser extension code base, separate them into assets of their given type and reference them.

This will allow for contributors to be able to make changes a lot more easily.

@nickytonline nickytonline added DX Developer experience enhancement New feature or request labels Aug 12, 2020
@benhalpern
Copy link
Contributor

This works for me as long as it doesn't interfere with the loading in any way. I feel like the way the extension renders before other parts of the HTML is a delicate balance. I assume this is fine but let's make sure this doesn't change behavior.

@nickytonline nickytonline added the type: discussion topics open for discussion label Aug 17, 2020
@Link2Twenty
Copy link
Contributor

Would the files be separate for development but rolled into one file for production?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DX Developer experience enhancement New feature or request type: discussion topics open for discussion
Projects
None yet
Development

No branches or pull requests

3 participants