Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Update listed Forems URL #63

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

atsmith813
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor

Description

Update the URL for listed/valid Forems

@fdocr
Copy link
Contributor

fdocr commented Aug 10, 2021

I'm wondering if there's something we can do to fix the CORS error I see locally. This is also happening in the current version from the Chrome extension store though, so this PR didn't exactly break it, but the fetch is definitely not succeeding for me.

Screen Shot 2021-08-10 at 14 15 10

@atsmith813 do you see the same error in your local environment?

@joshpuetz joshpuetz mentioned this pull request Aug 10, 2021
@joshpuetz
Copy link
Contributor

I created issue #64 for tracking a fix for the CORS issue. No need to block this PR!

Copy link
Contributor

@joshpuetz joshpuetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@atsmith813 atsmith813 merged commit 9173110 into main Aug 11, 2021
@atsmith813
Copy link
Contributor Author

@benhalpern @joshpuetz can you update the appropriate plugin stores?

@atsmith813 atsmith813 deleted the atsmith813/update-forem-directory-url branch August 11, 2021 19:42
@joshpuetz
Copy link
Contributor

@benhalpern @joshpuetz can you update the appropriate plugin stores?

I can track these releases down!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants