Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline links in only Markdown region #74

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Apr 19, 2022

Underline links in only Markdown region, i.e., remove underlines from (breadcrumbs), collapsible TOC (for mobile screen), footer including "Edit this page". Redundant CSS .pagination-nav__item a for navigations under the footer can be removed as well. Additional opinionated changes are made in the <footer>, which is the default style in Docusaurus default.

Area to apply text-decoration: underline before/after the patch

before this patch after this patch
container-1 theme-doc-markdown

Additional opinionated changes in <footer>

before this patch after this patch
developers forem com_technical-overview_stack 3000-forem-foremdocs-xvxy72t2s6p ws-us40 gitpod io_

Fixes up #1

Closes #68

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

@tnir
Copy link
Contributor Author

tnir commented Apr 19, 2022

@lisasy What do you think? cc @Zhao-Andy

@Zhao-Andy
Copy link
Contributor

@tnir Lisa isn't the point person here anymore so I'll loop our design team instead for their thoughts. :)

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir
Copy link
Contributor Author

tnir commented May 18, 2022

@Zhao-Andy Did you assign design team to review this?

@tnir
Copy link
Contributor Author

tnir commented Jul 5, 2022

Just a friendly reminder 👀

Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the ping @tnir ! this LGTM

@maestromac maestromac merged commit bb20acd into forem:main Jul 11, 2022
@tnir tnir deleted the tnir/narrower-css-68 branch July 11, 2022 22:23
@tnir
Copy link
Contributor Author

tnir commented Jul 11, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links are underlined in-page navigation only on mobile
3 participants