Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct @svgr/webpack v5 dependency with sole use of @svgr/webpack 6.2.1 #82

Conversation

tnir
Copy link
Contributor

@tnir tnir commented May 2, 2022

to partially address CVE-2021-3803 by removing nth-check 1.0.2 by removing css-select 2.1.0.

The code to be removed in this PR was initially introduced in f5a0a2d by @Zhao-Andy and has been untouched to date.

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

with sole use of @svgr/webpack 6.2.1.

docusaurus v2.0.0-beta.10 upgraded @svgr/webpack to 6
facebook/docusaurus#5958

to partially address CVE-2021-3803 by removing nth-check 1.0.2
by removing css-select 2.1.0.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir
Copy link
Contributor Author

tnir commented May 6, 2022

@Zhao-Andy What do you think?

@tnir
Copy link
Contributor Author

tnir commented May 12, 2022

@Zhao-Andy Thoughts?

@tnir
Copy link
Contributor Author

tnir commented Jun 1, 2022

@maestromac Thanks for the review. Can you merge this? Or get delayed to do so?

@jeremyf jeremyf merged commit 2ed195d into forem:main Jun 2, 2022
@tnir tnir deleted the tnir/make-svgr-webpack-indirect-dependency-via-docusaurus-core branch June 2, 2022 23:57
@tnir
Copy link
Contributor Author

tnir commented Jun 2, 2022

@jeremyf Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants