Fix social image order logic (#2645)

forem · May 1, 2019 · 7100eab · 7100eab
1 parent 5890542
commit 7100eab
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/app/helpers/social_image_helper.rb b/app/helpers/social_image_helper.rb
@@ -14,8 +14,6 @@ def user_social_image_url(user)
   end
 
   def article_social_image_url(article)
-    return legacy_article_social_image(article) unless use_new_social_url?(article)
-
     if (image = article.social_image || article.main_image || article.video_thumbnail_url)
       return cl_image_path(image,
                            type: "fetch",
@@ -27,7 +25,7 @@ def article_social_image_url(article)
                            fetch_format: "auto",
                            sign_url: true)
     end
-
+    return legacy_article_social_image(article) unless use_new_social_url?(article)
     article_social_preview_url(article, format: :png)
   end