Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring EditorAction #10947

Closed
Rafi993 opened this issue Oct 20, 2020 · 2 comments · Fixed by #10894
Closed

Refactoring EditorAction #10947

Rafi993 opened this issue Oct 20, 2020 · 2 comments · Fixed by #10894
Assignees
Labels
type: refactoring code refactors

Comments

@Rafi993
Copy link
Contributor

Rafi993 commented Oct 20, 2020

Describe the bug

  1. Refactoring EditorAction to remove nested ternary operators for better readability
  2. To convert class component into functional component

Additional context

Nested ternary operators are hard to debug. This is issue to make that component more readable

@github-actions
Copy link
Contributor

Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

@Rafi993 Rafi993 mentioned this issue Oct 20, 2020
11 tasks
@Rafi993
Copy link
Contributor Author

Rafi993 commented Oct 20, 2020

I have created the PR some time ago. I just created the issues now since it would be easier to track the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring code refactors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants