Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate or restructure admin-supplied content fields for accessibility #11842

Open
marcysutton opened this issue Dec 10, 2020 · 4 comments
Open
Labels
area: accessibility issues that need accessibility improvements (a11y) area: admin admin panel internal team only internal tasks only for Forem team members

Comments

@marcysutton
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The sponsorship widget in the left sidebar of Forem has accessibility issues, including missing alt text for an image wrapped in a link–causing an empty anchor to be rendered. This content area and other similar textfields should be updated to either validate the freeform content for accessibility, or be restructured into separate data fields to ensure accessible markup.

Describe the solution you'd like

There are a few options:

  • A plain textarea could have an accessibility checker run on it, for example the axe linter or CKEditor in the case of a WYSIWYG.
  • The textarea could instead be converted into structured data fields such as a link, image, and image alt text, preventing inaccessible markup from being inserted. It would be less flexible markup-wise, but easier to implement and enforce accessibility.

Describe alternatives you've considered

Fixing the accessibility issues themselves in Forem would satisfy these particular accessibility issues short-term, but wouldn't prevent them from occurring again on DEV or other Forem sites.

Additional context

Here are some screenshots from the accessibility issues found in the axe extension:

axe extension showing a "Links need discernible text" issue

The DEV homepage with the Chrome DevTools open to an image with no alt attribute

@github-actions
Copy link
Contributor

Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

@rhymes rhymes added area: accessibility issues that need accessibility improvements (a11y) area: admin admin panel bug always open for contribution labels Dec 10, 2020
@marcysutton
Copy link
Contributor Author

marcysutton commented Dec 10, 2020

Here's another example that appeared recently, the "campaignmode-hackathon", which has images with no alt text and an h1 with only a + in it:

Dev.to with a DigitalOcean Hackathon banner open in axe devtools
The hackathon banner open in Chrome DevTools showing images with no alt text

And one more, which I'm realizing is a flavor of the sponsorship widget: a DevDiscuss Podcast link, which isn't properly wrapping text so it ends up empty:
DevDiscuss podcast widget showing an empty link in Chrome DevTools

@cmgorton
Copy link
Contributor

@forem/frontend I know we have had several accessibility changes recently. is this something we have worked on? If not I think we should add this either to our planning funnel or I can add this to the MLH project board. Thoughts?

@nickytonline
Copy link
Contributor

This hasn't been worked on and most likely will require an RFC.

@cmgorton cmgorton added potential RFC internal team only internal tasks only for Forem team members and removed bug always open for contribution labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: accessibility issues that need accessibility improvements (a11y) area: admin admin panel internal team only internal tasks only for Forem team members
Projects
None yet
Development

No branches or pull requests

4 participants