New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netlify docsdevto build fails due to no content change #12108
Comments
Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue. To our amazing contributors: issues labeled To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days. For full info on how to contribute, please check out our contributors guide. |
Thanks for reporting this @bogdaaamn. I believe we'll need to change the Netlify config to avoid getting this error. cc: @Zhao-Andy. |
Thanks for bringing this up! The current setup is to cancel a Netlify build for docs.forem.com or storybook.forem.com in a PR. However, in Netlify cancelling a build does trigger a failed status. Theoretically this is all we need, but it is annoying to have it send the failed state over. I'm not sure if there's anything in Netlify's configuration that we can change to account for that. |
Note: whoever picks this up will need to obtain access to Netlify! |
Awaiting response from Netlify since I couldn't find an option to configure this. |
@Zhao-Andy Since you've started investigating/reaching out to netlify and assigned yourself to this issue, can we add this to in progress? :) |
Unfortunately Netlify support has told me this is an issue on their end, and not something we can configure. :( Related Netlify community post: https://community.netlify.com/t/status-badge-incorrectly-shows-failing-when-deploy-is-auto-cancelled/7316 We can remove the badge and any related commit statuses from the repo, or continue as we currently have until it is fixed by Netlify. |
Thank you for the heads-up @Zhao-Andy ✨ |
Describe the bug
Netlify docsdevto is built on every github.com/forem/forem PR and fails if there is no content change.
snippet from master@e41c995 build
To Reproduce
Expected behavior
While this is not an real issue (Netlify builds do suceed when changes are pushed) I am just thinking if the build status influence other parts of the system (I first noticed the README Netlify tag).
Or open up a discussion about the possibilities of strategically building the docsdevto to reduce the no-content builds – or if it's worth the effort to change it.
The text was updated successfully, but these errors were encountered: