Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify docsdevto build fails due to no content change #12108

Closed
bogdaaamn opened this issue Jan 4, 2021 · 8 comments · Fixed by #12376
Closed

Netlify docsdevto build fails due to no content change #12108

bogdaaamn opened this issue Jan 4, 2021 · 8 comments · Fixed by #12376
Assignees
Labels
area: documentation Issues/PRs related to Forem documentation changes blocked blocked by internal or external issues bug always open for contribution internal team only internal tasks only for Forem team members size: estimated XS less than a few days to complete

Comments

@bogdaaamn
Copy link
Contributor

Describe the bug

Netlify docsdevto is built on every github.com/forem/forem PR and fails if there is no content change.

10:54:33 AM: No changes detected in base directory. Returning early from build.
10:54:33 AM: Failed during stage 'checking build content for changes': Canceled build due to no content change
10:54:33 AM: Finished processing build request in 19.336942253s

snippet from master@e41c995 build

To Reproduce

Expected behavior

While this is not an real issue (Netlify builds do suceed when changes are pushed) I am just thinking if the build status influence other parts of the system (I first noticed the README Netlify tag).

Or open up a discussion about the possibilities of strategically building the docsdevto to reduce the no-content builds – or if it's worth the effort to change it.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2021

Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

@nickytonline nickytonline added area: documentation Issues/PRs related to Forem documentation changes internal team only internal tasks only for Forem team members bug always open for contribution labels Jan 4, 2021
@nickytonline
Copy link
Contributor

Thanks for reporting this @bogdaaamn. I believe we'll need to change the Netlify config to avoid getting this error. cc: @Zhao-Andy.

@Zhao-Andy
Copy link
Contributor

Thanks for bringing this up! The current setup is to cancel a Netlify build for docs.forem.com or storybook.forem.com in a PR. However, in Netlify cancelling a build does trigger a failed status. Theoretically this is all we need, but it is annoying to have it send the failed state over. I'm not sure if there's anything in Netlify's configuration that we can change to account for that.

@vaidehijoshi
Copy link
Contributor

Note: whoever picks this up will need to obtain access to Netlify!

@mstruve mstruve added this to Miscellaneous (non technical) in Current Cycle Work Jan 14, 2021
@mstruve mstruve added the size: estimated XS less than a few days to complete label Jan 14, 2021
@Zhao-Andy Zhao-Andy self-assigned this Jan 20, 2021
@Zhao-Andy Zhao-Andy moved this from Miscellaneous to In Progress 🖥 in Current Cycle Work Jan 20, 2021
@Zhao-Andy
Copy link
Contributor

Awaiting response from Netlify since I couldn't find an option to configure this.

@Zhao-Andy Zhao-Andy added the blocked blocked by internal or external issues label Jan 20, 2021
@Zhao-Andy Zhao-Andy moved this from In Progress 🖥 to Miscellaneous in Current Cycle Work Jan 20, 2021
@vaidehijoshi
Copy link
Contributor

@Zhao-Andy Since you've started investigating/reaching out to netlify and assigned yourself to this issue, can we add this to in progress? :)

@Zhao-Andy Zhao-Andy moved this from Miscellaneous to In Progress 🖥 in Current Cycle Work Jan 20, 2021
@Zhao-Andy
Copy link
Contributor

Unfortunately Netlify support has told me this is an issue on their end, and not something we can configure. :(

Related Netlify community post: https://community.netlify.com/t/status-badge-incorrectly-shows-failing-when-deploy-is-auto-cancelled/7316

We can remove the badge and any related commit statuses from the repo, or continue as we currently have until it is fixed by Netlify.

@Zhao-Andy Zhao-Andy moved this from In Progress 🖥 to DONE 🎉 in Current Cycle Work Jan 26, 2021
@Zhao-Andy Zhao-Andy moved this from DONE 🎉 to Blocked 🛑 in Current Cycle Work Jan 27, 2021
@bogdaaamn
Copy link
Contributor Author

Thank you for the heads-up @Zhao-Andy

Current Cycle Work automation moved this from Blocked 🛑 to DONE 🎉 Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation Issues/PRs related to Forem documentation changes blocked blocked by internal or external issues bug always open for contribution internal team only internal tasks only for Forem team members size: estimated XS less than a few days to complete
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants