Bad regex for detecting SVG on Navigation Links

[omenking]

The dreaded error:

Code in question:

class NavigationLink < ApplicationRecord
  SVG_REGEXP = /<svg .*>/i.freeze

Testing with rubular

So the problem is that the Regex expects svg text to be all on a single line:

When exporting svg from illustrator it will sometimes insert a XML schema tag first.

Yep Single line formatting fixed it:

[github-actions]

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

[rhymes]

@omenking I took a quick look but I wasn't able to reproduce, can you please describe what you did and attach the media if possible?

[SiddharthShyniben]

I think this can be fixed by giving the regex the DOTALL (s) flag

[SiddharthShyniben]

@rhymes I think the problem is the current regex doesn't match any newlines, so if the SVG contains newlines in the <svg> tag, this regex doesn't match.

So this matches:

<svg ...>

But this wont:

<svg ...
     ...>

[citizen428]

@SiddharthShyniben The flag to make . match newlines in Ruby is m but otherwise, you're correct.

https://rubular.com/r/3CCXiqFPznQdkh

Do you want to make a PR? 😃

[SiddharthShyniben]

@citizen428 Sure! I'll take this up