Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Leading Whitespace From Email and Social Links in the Admin Member Detail View #16521

Open
1 task
Ridhwana opened this issue Feb 10, 2022 · 2 comments
Open
1 task
Labels
area: admin admin panel internal team only internal tasks only for Forem team members tech: backend changes will be primarily on the backend

Comments

@Ridhwana
Copy link
Contributor

Ridhwana commented Feb 10, 2022

馃摉 As an Admin, I want my UI to be aesthetically pleasing as possible, so that I feel motivated to use the Admin Member Detail View.

馃悾 TASKS

  • Remove the leading whitespace from the user's email address and social links.

Note: For more information, please reference this comment from the initial Admin Member Detail View PR.

@Ridhwana Ridhwana changed the title Whitespaces in links Whitespaces in some links Feb 10, 2022
@github-actions
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem/oss. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@Ridhwana Ridhwana added the internal team only internal tasks only for Forem team members label Feb 10, 2022
@juliannatetreault juliannatetreault added area: admin admin panel tech: backend changes will be primarily on the backend labels Feb 10, 2022
@juliannatetreault juliannatetreault changed the title Whitespaces in some links Remove Leading Whitespace From Email and Social Links in the Admin Member Detail View Feb 10, 2022
@metamoni
Copy link
Contributor

Hello 馃憢

I'm not sure this is a backend issue, it looks like erb just adds spaces around text that's not wrapped in an HTML element. If you wrap the text in a span, the extra whitespaces disappear.

Screenshot 2022-02-20 at 22 50 09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: admin admin panel internal team only internal tasks only for Forem team members tech: backend changes will be primarily on the backend
Projects
Development

No branches or pull requests

4 participants