Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invited Members: Bulk Invite Users #17453

Open
1 task
Tracked by #17450
aitchiss opened this issue Apr 27, 2022 · 5 comments
Open
1 task
Tracked by #17450

Invited Members: Bulk Invite Users #17453

aitchiss opened this issue Apr 27, 2022 · 5 comments
Assignees
Labels
area: admin admin panel internal team only internal tasks only for Forem team members tech: fullstack changes will heavily involve both frontend and backend technologies

Comments

@aitchiss
Copy link
Contributor

aitchiss commented Apr 27, 2022

πŸ“– As an Admin, I want my experience with invitations to be as pleasing and straightforward as possible, so that I feel motivated to use them.

βœ… Tasks to complete:

  • Alter the new invite member flow to bulk invite users ( new page workflow + bulk invite + account for validation + success and error states )

Screenshot 2022-05-03 at 20 28 19

Screenshot 2022-05-03 at 20 29 07

Screenshot 2022-05-03 at 20 29 31

@github-actions
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

Feature requests that require more discussion may be closed. Read more about our feature request process on forem.dev.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@aitchiss aitchiss added the internal team only internal tasks only for Forem team members label Apr 27, 2022
@juliannatetreault juliannatetreault added area: admin admin panel tech: fullstack changes will heavily involve both frontend and backend technologies labels Apr 27, 2022
@juliannatetreault juliannatetreault changed the title Alter the new invite member flow to bulk invite users ( new page workflow + bulk invite + account for validation + success and error states ) Invited Members: Bulk Invite Users Apr 27, 2022
@Ridhwana Ridhwana self-assigned this May 2, 2022
@Ridhwana
Copy link
Contributor

Ridhwana commented May 3, 2022

@aitchiss do you have any initial thoughts or tips for the Preact Component for the email addresses that I should take into consideration? It would probably need to be custom built right (i.e. without a library)? I see it being similar in UI as the MultipleSelectAutoComplete (in the way that the UI looks and without the autocompletion).

@aitchiss
Copy link
Contributor Author

aitchiss commented May 4, 2022

Yeah I've been mulling this over @Ridhwana.. one option I was weighing up is altering the MultiSelectAutocomplete so that it supports both autocomplete and non-autocomplete behaviours πŸ€” Because, like you say the behaviours and UI we're looking for are so similar.

For example, we could rename the component from MultiSelectAutocomplete to something like MultiSelectInput and give it a autocomplete boolean prop to determine whether it's a 'normal' input or a 'suggesting' input. The thing that gives me pause though is that for this particular use case we need to also add in validation after the user makes their selection, including error UI etc. And the MultiSelectAutocomplete component is already quite complicated.

TL;DR - for now perhaps the best move is to make a separate Preact component (e.g. MultiEntryInput or some other name), and keep an eye for any abstractions we can make in the MultiSelectAutocomplete to support that? What do you think? We can definitely borrow a lot of styles, keyboard behaviours etc from the MultiSelectAutocomplete.

I'd probably recommend that we break this task down further into:

  • Create a crayons component in Storybook
  • Implement it in the admin area (which will need to include some kind of progressive enhancement since it's Preact)

@Ridhwana
Copy link
Contributor

Ridhwana commented May 4, 2022

TL;DR - for now perhaps the best move is to make a separate Preact component (e.g. MultiEntryInput or some other name), and keep an eye for any abstractions we can make in the MultiSelectAutocomplete to support that? What do you think? We can definitely borrow a lot of styles, keyboard behaviours etc from the MultiSelectAutocomplete.

I'd probably recommend that we break this task down further into:

Create a crayons component in Storybook
Implement it in the admin area (which will need to include some kind of progressive enhancement since it's Preact)

I like this and think it's the most logical way forward ✨. Thank you so much for jotting down your thoughts! I'll break up the tasks and start off by taking a stab at the crayons component which means I may ping you from time to time for some support if that's okay?

@aitchiss
Copy link
Contributor Author

aitchiss commented May 4, 2022

Sounds good! In the end, if you see they're more alike then we can always later refactor to combine them πŸ™‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: admin admin panel internal team only internal tasks only for Forem team members tech: fullstack changes will heavily involve both frontend and backend technologies
Projects
None yet
Development

No branches or pull requests

3 participants