-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HardCoded AWS Image URLs and Download Images into /assets #5810
Comments
I will do it. |
Thank you @seb1441, you're on a roll 👍 |
@seb1441 a small suggestion: it's better to have multiple small PRs than one huge one, if you find yourself working on too many files :) Thank you! |
@rhymes I will have around 30 files (mainly views) to update for this PR, but it's mostly one line changes. Would you recommend me to split that into multiple PRs like 10 files each? Another question, is it the right way to take issues to just write "I will do it"? 😆 |
@seb1441 I think 30 is fine, thank you! Declaring your intentions is also fine, this way we can assign the issue to you so nobody will attempt to solve the same problem. Thank you a lot for your contributions and.. welcome to open source I guess :-D |
We still have these in our docs but all have been removed from the codebase thanks to our recent generalization push 😄 |
Throughout our codebase, we have a lot of hardcoded AWS image urls. Here is an example of a few of them. There are even more examples sprinkled all over the views.
Rather than updating the AWS bucket name everywhere which will break for many people's local integrations we should download these images and add them to the
/assets/images
directory so they can be served directly from the app. In addition, we should give those that we download pertinent names relating to what they are so when another community would like to spin up this codebase for their own purposes they can replace the images with ones that represent their use case.The text was updated successfully, but these errors were encountered: