Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HardCoded AWS Image URLs and Download Images into /assets #5810

Closed
mstruve opened this issue Jan 29, 2020 · 6 comments
Closed

Remove HardCoded AWS Image URLs and Download Images into /assets #5810

mstruve opened this issue Jan 29, 2020 · 6 comments
Labels
area: generalization New communities and generalization of the codebase external contributors welcome contribution is welcome! type: refactoring code refactors

Comments

@mstruve
Copy link
Contributor

mstruve commented Jan 29, 2020

Throughout our codebase, we have a lot of hardcoded AWS image urls. Here is an example of a few of them. There are even more examples sprinkled all over the views.

Rather than updating the AWS bucket name everywhere which will break for many people's local integrations we should download these images and add them to the /assets/images directory so they can be served directly from the app. In addition, we should give those that we download pertinent names relating to what they are so when another community would like to spin up this codebase for their own purposes they can replace the images with ones that represent their use case.

@rhymes rhymes added area: generalization New communities and generalization of the codebase external contributors welcome contribution is welcome! ruby type: refactoring code refactors labels Jan 29, 2020
@websebdev
Copy link
Contributor

I will do it.

@citizen428
Copy link
Contributor

Thank you @seb1441, you're on a roll 👍

@rhymes
Copy link
Contributor

rhymes commented Jan 30, 2020

@seb1441 a small suggestion: it's better to have multiple small PRs than one huge one, if you find yourself working on too many files :)

Thank you!

@websebdev
Copy link
Contributor

@rhymes I will have around 30 files (mainly views) to update for this PR, but it's mostly one line changes. Would you recommend me to split that into multiple PRs like 10 files each?

Another question, is it the right way to take issues to just write "I will do it"? 😆
As you probably noticed, it's my first time working on an open source project.

@rhymes
Copy link
Contributor

rhymes commented Jan 30, 2020

@seb1441 I think 30 is fine, thank you! Declaring your intentions is also fine, this way we can assign the issue to you so nobody will attempt to solve the same problem.

Thank you a lot for your contributions and.. welcome to open source I guess :-D

@mstruve
Copy link
Contributor Author

mstruve commented Sep 30, 2020

We still have these in our docs but all have been removed from the codebase thanks to our recent generalization push 😄

@mstruve mstruve closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: generalization New communities and generalization of the codebase external contributors welcome contribution is welcome! type: refactoring code refactors
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants