Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide overflow text #10159

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Hide overflow text #10159

merged 1 commit into from
Sep 2, 2020

Conversation

Link2Twenty
Copy link
Contributor

@Link2Twenty Link2Twenty commented Sep 2, 2020 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Hide overflow text caused be unbreakable words and urls (notification-comment-reacted-link)

Related Tickets & Documents

closes #10121

QA Instructions, Screenshots, Recordings

  1. Leave a long word or URL as a a comment
  2. Get a reaction (like/unicorn)
  3. See text no longer overflows box.

Before:
before image

After:
after image

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

Get in there

@Link2Twenty
Hide overflow text
f37bc9d 
Hide overflow text caused be unbreakable words and urls (notification-comment-reacted-link)
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Sep 2, 2020
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Sep 2, 2020
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Sep 2, 2020
@ludwiczakpawel ludwiczakpawel merged commit a6d01f3 into forem:master Sep 2, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Sep 2, 2020
@Link2Twenty Link2Twenty deleted the patch-1 branch September 2, 2020 14:30
citizen428 pushed a commit that referenced this pull request Sep 3, 2020
@Link2Twenty
Hide overflow text (#10159)
3d7fadf 
Hide overflow text caused be unbreakable words and urls (notification-comment-reacted-link)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludwiczakpawel ludwiczakpawel ludwiczakpawel approved these changes

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link in notification overflows
3 participants
@Link2Twenty @ludwiczakpawel @benhalpern