Add twitch liquid tags #10577
Add twitch liquid tags #10577
Conversation
pr-triage
bot
added
the
PR: draft
|
|
These will embed Twitch Clips in articles and comments.
ChaelCodes
force-pushed
the
10475-Add-twitch-liquid-tags
branch
from
05d418b
to
e3ce56b
Compare
pr-triage
bot
added
PR: unreviewed
There was a problem hiding this comment.
Tested, it works great!
I left a non blocking note about making the tests a little bit more self explanatory but great job @ChaelCodes!
I also left a question :P
| def parsed_url(url) | ||
| url.split(":")[0] | ||
| end |
There was a problem hiding this comment.
I was going to suggest using ApplicationConfig.app_domain_no_port but that's tied to the environment variable. Let's keep this here, I'll add a SiteConfig.app_domain_no_port in a separate PR not to derail this one :)
|
|
||
| # prevent param injection | ||
| def parsed_slug(slug) | ||
| slug.strip.split("&")[0] |
There was a problem hiding this comment.
FYI non blocking for-the-future: you can use .first instead of [0]
| @@ -14,6 +14,7 @@ def has_vid?(article) | |||
|
|
|||
| article.processed_html.include?("youtube.com/embed/") || | |||
| article.processed_html.include?("player.vimeo.com") || | |||
| article.processed_html.include?("clips.twitch.tv/embed") || | |||
There was a problem hiding this comment.
can I ask you the reason for this change? I'm not super familiar with that part of the code, so I'm wondering why we need Fluidvids for a liquid tag if it's in an iframe, is it for the potential resizing of the container?
| it "forbids inserting autoplay option" do | ||
| assert_parses slug, "#{slug}&autoplay=true" | ||
| end |
There was a problem hiding this comment.
this test is not very self explanatory. "assert it parses the slug if you pass the slug with autoplay true" but maybe we should test "make sure the slug doesn't contain autoplay=true"
| end | ||
|
|
||
| it "forbids inserting mute option" do | ||
| assert_parses slug, "#{slug}&muted=true" |
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
* Add a Liquid Tag specifically for Twitch clips. These will embed Twitch Clips in articles and comments. * Update documentation to incorporate Twitch clip liquid tags. * Include Twitch Clips in video embed logic * Making a small change to rebuild
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
resolves #10475
Twitch Documentation on Embeds
Dev.To docs on Liquid Tags
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.
Added tests?
Added to documentation?