Update BatchRewarder::REPOSITORIES #10593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizen428
requested review from
benhalpern,
a team and
jacobherrington
and removed request for
a team
citizen428
commented
Oct 5, 2020
| @@ -1,6 +1,11 @@ | |||
| module BadgeRewarder | |||
| YEARS = { 1 => "one", 2 => "two", 3 => "three", 4 => "four", 5 => "five", 6 => "six", 7 => "seven" }.freeze | |||
| REPOSITORIES = ["thepracticaldev/dev.to", "thepracticaldev/DEV-ios", "thepracticaldev/DEV-Android"].freeze | |||
| REPOSITORIES = [ | |||
| "forem/forem", | |||
There was a problem hiding this comment.
This replaced "thepracticaldev/dev.to".
| REPOSITORIES = ["thepracticaldev/dev.to", "thepracticaldev/DEV-ios", "thepracticaldev/DEV-Android"].freeze | ||
| REPOSITORIES = [ | ||
| "forem/forem", | ||
| "forem/forem-browser-extension", |
citizen428
requested review from
Ridhwana and
joshpuetz
and removed request for
jacobherrington
Ridhwana
approved these changes
Oct 6, 2020
pr-triage
bot
added
PR: partially-approved
joshpuetz
approved these changes
Oct 6, 2020
citizen428
deleted the
citizen428/update-batch-rewarder-repositories-10064
branch
pr-triage
bot
added
PR: merged
boardfish
pushed a commit
to boardfish/forem
that referenced
this pull request
Oct 17, 2020
* Update BatchRewarder::Repositories * Sort constant alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
While looking at #10064 I realized that we never updated
BatchRewarder::REPOSITORIESto reflect the move fromThePracticalDev/dev.totoforem/forem. I also addedforem/forem-browser-extensionsince it's open-source and had external contributions already.Related Tickets & Documents
Related to #10064
QA Instructions, Screenshots, Recordings
n/a
Added tests?
Added to documentation?