New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Endpoint to get an organization's details #10931
API: Endpoint to get an organization's details #10931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @twinsfan421! Code looks super solid here. Could you also add some API docs for this new endpoint? docs/api_v0.yml
Please and thank you!!!
PS also looks like there is a routes.rb conflict :)
@mstruve Ok thanks, will do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. This should include an update to the API docs, as per described here. https://docs.forem.com/contributing/api/
Here's an example of the last PR with API changes that include the docs. #10547
6e7d6aa
to
4009005
Compare
I pushed up a fix for the merge conflict and an update to the api docs. Let me know if you want me to make any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @twinsfan421, great work! I would align the joined/creation date to the format of the other dates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the changes @twinsfan421, one tiny last bit left :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @twinsfan421, LGTM!
What type of PR is this? (check all applicable)
Description
This would provide an api show endpoint
dev.to/api/organizations/{org_username}
to search organizations by their username.As discussed in issue 9212, This is the first of 4 related endpoints that will include:
Related Tickets & Documents
#9212
Added tests?
Added to documentation?