Bug Fix:Update dev.to check to use DEV Community #12082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdoss
approved these changes
Dec 30, 2020
pr-triage
bot
added
PR: partially-approved
msarit
approved these changes
Dec 30, 2020
atsmith813
approved these changes
Dec 30, 2020
maestromac
approved these changes
Dec 30, 2020
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
|
I wonder if we could use the dev_to method here instead of relying on the community name. I had no idea that we were checking against the hardcoded string! forem/app/models/site_config.rb Line 215 in 6b0626a |
|
Yeah @vaidehijoshi I was just thinking the same thing. I think the domain name is less prone to change |
|
100% game for that. I will make a follow-up PR! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we changed our site name on dev.to from DEV to DEV Community. This is used in our code in a couple of places and needs to be updated. From a prod console
Without the guard clauses working properly we enqueued our Email Digest worker which takes hours to complete for DEV bc of all the users. Since we restart Sidekiq on every deployment, this worker was continuously restarting which is why the duplicate emails were getting sent.