New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 1: Shows Relevant #help Posts in Homepage Sidebar #12670
Merged
juliannatetreault
merged 4 commits into
master
from
juliannatetreault/sidebar-help-tag-shows-relevant-posts-20
Mar 1, 2021
Merged
Part 1: Shows Relevant #help Posts in Homepage Sidebar #12670
juliannatetreault
merged 4 commits into
master
from
juliannatetreault/sidebar-help-tag-shows-relevant-posts-20
Mar 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
the
PR: draft
bot applied label for PR's that are a work in progress
label
Feb 11, 2021
juliannatetreault
changed the title
Part 1: Shows Relevant #help Posts in Sidebar
Part 1: Shows Relevant #help Posts in Homepage Sidebar
Feb 11, 2021
citizen428
reviewed
Feb 15, 2021
citizen428
reviewed
Feb 15, 2021
- Reverts change from scope to class method, back to scope - Updates to use newer AR query syntax using endless ranges - Refactors scope to be more concise
juliannatetreault
force-pushed
the
juliannatetreault/sidebar-help-tag-shows-relevant-posts-20
branch
from
February 25, 2021 19:26
b4610c9
to
57b8007
Compare
pr-triage
bot
added
PR: unreviewed
bot applied label for PR's with no review
and removed
PR: draft
bot applied label for PR's that are a work in progress
labels
Feb 25, 2021
citizen428
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
pr-triage
bot
added
PR: partially-approved
bot applied label for PR's where a single reviewer approves changes
and removed
PR: unreviewed
bot applied label for PR's with no review
labels
Feb 26, 2021
rhymes
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA'ed it! Let's do this!
juliannatetreault
deleted the
juliannatetreault/sidebar-help-tag-shows-relevant-posts-20
branch
March 1, 2021 17:24
pr-triage
bot
added
PR: merged
bot applied label for PR's that are merged
and removed
PR: partially-approved
bot applied label for PR's where a single reviewer approves changes
labels
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The "Definition of Done" for this RFC is:
This PR is part one of a two-part solution to ensure that posts show beneath the tags in the homepage's righthand sidebar, regardless of the Forem's size and the article's
published_at
date,score
, andcomment_count
. The first part of this two-part solution focuses specifically on the #help tag in the homepage's righthand sidebar. To accomplish this, I've updated theactive_help
scope the Article model. This scope is responsible for determining which posts to show under the #help tag found in the homepage's righthand sidebar. In addition to this, I've added a test for this work tospec/models/article_spec.rb
.Related Tickets & Documents
Relates to RFC 20
QA Instructions, Screenshots, Recordings
/admin/config
and scroll to the/tags
section:#active_help
requirements, first drop into the console and update the article to matchwhere(published_at: 12.hours.ago.., comments_count: ..5, score: -3..)
:UI accessibility concerns?
I don't believe so!
Added tests?
have not been included
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
👀 I've added documentation to the Admin Guide. The draft can be found here. Any and all feedback welcome!
or in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post-deployment tasks we need to perform?
This will need to be deployed to all Forems.
[optional] What gif best describes this PR or how it makes you feel?