Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input scroll from position #13569

Merged

Conversation

Link2Twenty
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

When an input has a scroll we remove its position from the overall position putting the mention popover in the right place

Related Tickets & Documents

closes #13513

QA Instructions, Screenshots, Recordings

comment
post

UI accessibility concerns?

N/A

Added tests?

  • Yes
  • No, and this is why: existing tests will still work
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

Doctor who pops his head over a wall appearing all sweaty

As a side note I finally installed a local copy of forem rather than just winging it 😅

@Link2Twenty Link2Twenty requested review from a team, Ridhwana and jacobherrington and removed request for a team April 28, 2021 18:59
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 28, 2021
@github-actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@Link2Twenty
Copy link
Contributor Author

As another aside ddtrace 0.48.0 doesn't work, I had to force downgrade to 0.47.0 to get the forem setup to work

@rhymes
Copy link
Contributor

rhymes commented Apr 29, 2021

@Link2Twenty sorry about that, we eventually reverted to 0.47 #13570

@Link2Twenty
Copy link
Contributor Author

@Link2Twenty sorry about that, we eventually reverted to 0.47 #13570

It's alright, most of my debugging time was spent trying to work out what I did wrong, once I realised it wasn't my fault it was an easy fix 😅

@Link2Twenty
Copy link
Contributor Author

I don't think the Travis fail is me, can someone verify?

@rhymes
Copy link
Contributor

rhymes commented Apr 29, 2021

Nope, not related to your code, @Link2Twenty. I re-ran Travis!

Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 29, 2021
@rhymes rhymes requested a review from aitchiss April 29, 2021 08:48
Copy link
Contributor

@aitchiss aitchiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks for taking this on - looks great to me ✨

@rhymes rhymes merged commit 59c7e25 into forem:main Apr 29, 2021
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Apr 29, 2021
@cmgorton
Copy link
Contributor

Thanks for taking the time to work on this @Link2Twenty !

@Link2Twenty Link2Twenty deleted the Link2Twenty/mention_long_comments_patch branch April 29, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long comments with @-mentions cause rendering issues
4 participants