-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove input scroll from position #13569
Remove input scroll from position #13569
Conversation
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
As another aside ddtrace 0.48.0 doesn't work, I had to force downgrade to 0.47.0 to get the forem setup to work |
@Link2Twenty sorry about that, we eventually reverted to 0.47 #13570 |
It's alright, most of my debugging time was spent trying to work out what I did wrong, once I realised it wasn't my fault it was an easy fix 😅 |
I don't think the Travis fail is me, can someone verify? |
Nope, not related to your code, @Link2Twenty. I re-ran Travis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Thanks for taking this on - looks great to me ✨
Thanks for taking the time to work on this @Link2Twenty ! |
What type of PR is this? (check all applicable)
Description
When an input has a scroll we remove its position from the overall position putting the mention popover in the right place
Related Tickets & Documents
closes #13513
QA Instructions, Screenshots, Recordings
UI accessibility concerns?
N/A
Added tests?
[optional] Are there any post deployment tasks we need to perform?
N/A
[optional] What gif best describes this PR or how it makes you feel?
As a side note I finally installed a local copy of forem rather than just winging it 😅