Change header name to double quoted string literal #13949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a rubocop warning
djuber
requested review from
a team,
Zhao-Andy and
juliannatetreault
and removed request for
a team
Zhao-Andy
approved these changes
Jun 9, 2021
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: reviewed-approved
citizen428
approved these changes
Jun 10, 2021
|
@djuber I went ahead and merged this because we have two Rubocop PRs in the pipeline and I didn't want to overwrite your PR |
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fixes a rubocop warning
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Run rubocop on the file and confirm no warnings.
UI accessibility concerns?
Added tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Admin Guide, or
Storybook (for Crayons components)
or in a forem.dev post
[optional] What gif best describes this PR or how it makes you feel?
Wow, github loves full sized images.
