Bump rubocop-rspec from 2.3.0 to 2.4.0

[dependabot]

Bumps rubocop-rspec from 2.3.0 to 2.4.0.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.4.0

• Update RSpec/FilePath to check suffix when given a non-constant top-level node (e.g. features). (@​topalovic)
• Add missing documentation for single_statement_only style of RSpec/ImplicitSubject cop. (@​tejasbubane)
• Fix an exception in DescribedClass when accessing a constant on a variable in a spec that is nested in a namespace. (@​rrosenblum)
• Add new RSpec/IdenticalEqualityAssertion cop. (@​tejasbubane)
• Add RSpec/Rails/AvoidSetupHook cop. (@​paydaylight)
• Fix false negative in RSpec/ExpectChange cop with block style and chained method call. (@​tejasbubane)

Changelog

Sourced from rubocop-rspec's changelog.

2.4.0 (2021-06-09)

• Update RSpec/FilePath to check suffix when given a non-constant top-level node (e.g. features). ([@​topalovic][])
• Add missing documentation for single_statement_only style of RSpec/ImplicitSubject cop. ([@​tejasbubane][])
• Fix an exception in DescribedClass when accessing a constant on a variable in a spec that is nested in a namespace. ([@​rrosenblum][])
• Add new RSpec/IdenticalEqualityAssertion cop. ([@​tejasbubane][])
• Add RSpec/Rails/AvoidSetupHook cop. ([@​paydaylight][])
• Fix false negative in RSpec/ExpectChange cop with block style and chained method call. ([@​tejasbubane][])

Commits

• 1b360e5 Merge pull request #1159 from rubocop/release
• b82febd Bump version to 2.4.0
• 2d00dbb Merge pull request #1158 from topalovic/file-path-check-suffix-for-non-const
• c4646ff Make FilePath check suffix when given a non-const top-level node
• 0be6148 Merge pull request #1152 from tejasbubane/fix-1143
• 0cbc140 Add more specs for RSpec/ExpectChange
• c3dd64a Fix false negative in RSpec/ExpectChange cop with block style and chained m...
• 9e55194 Merge pull request #1133 from paydaylight/add-prefer-before-over-setup-cop
• e94b463 Add RSpec/Rails/AvoidSetupHook cop
• e0e109c Merge pull request #1132 from tejasbubane/fix-1130
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[djuber]

it looks like the rename of the moderator moderates an article spec (which caused rspec to start running it) uncovered a previously broken test

forem/spec/system/articles/moderator_moderates_an_article_spec.rb

Line 23 in 7b01116

expect(page).to have_content("Moderate: #{article.title}")

fails in main (using the old file) and in this branch (using the renamed file) and is not tied to this upgrade (we should probably keep the rename and xit or xdescribe the spec and open a separate issue for it).

On main I see the same issue we do in travis runs:

Failures:

  1) Views an article lets moderators visit /mod
     Failure/Error: expect(page).to have_content("Moderate: #{article.title}")
       expected to find text "Moderate: The Widening Gyre2" in "Skip to content\nDEV(local)\nCreate Post\nConnect\nNotifications\nSetup not completed yet, missing suggested tags and suggested users. Please visit the configuration page.\nThe Widening Gyre2\n@username4\nHigh Quality\nLow Quality\nFlag to Admins\nAll negative reactions are private.\nUse High Quality to move this content \"up\" for any reason (quality, usefulness, etc.).\nUse Low Quality to move this content \"down\" for any reason (quality, usefulness, etc.).\nUse Flag to Admins for code of conduct violations (harassment, being a jerk, spam, etc.).\nFlag username4 as Abusive\nFlag User\nThis is the equivalent of vomiting on all of this user's articles and will lower their article scores.\nExperience Level of Post\n1 - Novice\n2 - Beginner\n3 - Mid-level\n4 - Advanced\n5 - Expert\nWho might find this post most valuable, based on overall experience level?\nHome Create Post\nDEV(local) – Some description\nBuilt on Forem — the open source software that powers DEV and other inclusive communities.\nMade with love and Ruby on Rails. DEV(local) © 2021.\nForem logo"
     
     [Screenshot Image]: /home/djuber/src/forem/tmp/screenshots/failures_r_spec_example_groups_views_an_article_lets_moderators_visit__mod_949.png

     
     # ./spec/system/articles/moderator_moderates_an_article.rb:23:in `block (2 levels) in <top (required)>' 
     # ./spec/rails_helper.rb:144:in `block (3 levels) in <top (required)>'
     # ./spec/rails_helper.rb:144:in `block (2 levels) in <top (required)>'
     # ./spec/rails_helper.rb:98:in `block (2 levels) in <top (required)>'

Finished in 22.83 seconds (files took 2.65 seconds to load)
3 examples, 1 failure

Failed examples:

rspec ./spec/system/articles/moderator_moderates_an_article.rb:20 # Views an article lets moderators visit /mod                                                           

I'll just remove the expectation that "Moderate:" show on the page for now (we do get the downvote and article/user vomit reactions which is the moderation control set).

[rhymes]

Thank you @djuber!