Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Devise emails asynchronously #13985

Merged
merged 3 commits into from Jun 15, 2021
Merged

Send Devise emails asynchronously #13985

merged 3 commits into from Jun 15, 2021

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Jun 15, 2021 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

By default, Devise emails are sent synchronously in after_commit callbacks, which means that if any of the callbacks fail (which happened recently when we misconfigured email sending), then all following callbacks aren't run.

I can't find a reason to have invitation and confirmation emails being sent synchronously, thus I'm following Devise instructions to use ActiveJob for those emails and thus the async queue.

Related Tickets & Documents

#13983

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Jun 15, 2021
@rhymes rhymes requested a review from citizen428 June 15, 2021 08:23
@rhymes rhymes marked this pull request as ready for review June 15, 2021 08:23
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Jun 15, 2021
@rhymes rhymes added the merge by any core This tag is a signal that you are okay with any core team member merging your code for you. label Jun 15, 2021
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 15, 2021
mstruve
mstruve approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fdocr fdocr merged commit 43f84c1 into main Jun 15, 2021
@fdocr fdocr deleted the rhymes/send-devise-emails-asynchronously branch June 15, 2021 13:50
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 approved these changes

@mstruve mstruve mstruve approved these changes

@fdocr fdocr fdocr approved these changes

@djuber djuber Awaiting requested review from djuber

@maestromac maestromac Awaiting requested review from maestromac

@Zhao-Andy Zhao-Andy Awaiting requested review from Zhao-Andy

Assignees
No one assigned
Labels
merge by any core This tag is a signal that you are okay with any core team member merging your code for you. PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhymes @citizen428 @mstruve @fdocr