Create Default Nav Links In New Forem (RFC #237)

[msarit]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

As mentioned in the Static Nav Sections PR, this PR ensures that new forems have the default links prescribed by the Static Sections RFC.
❓❓ WHY do I have so many commits? I tried rebasing but that just added MORE commits! 😫

QA Instructions, Screenshots, Recordings

Run specs locally and ensure they pass.

UI accessibility concerns?

None.

Added/updated tests?

• Yes
• No, and this is why: please replace this line with details on why tests
  have not been included
• I need help with writing tests

[Forem core team only] How will this change be communicated?

• I've updated the Developer Docs and/or
  Admin Guide, or
  Storybook (for Crayons components)
• I've updated the README or added inline documentation
• I will share this change in a Changelog
  or in a forem.dev post
• I will share this change internally with the appropriate teams
• I'm not sure how best to communicate this change and need help
• This change does not need to be communicated, and this is why not: please
  replace this line with details on why this change doesn't need to be
  shared

[djuber]

It's probably just code golf, but you could make a local helper method for image_content(*paths) and save a few bytes - the image_content exists for the one rainbowdev image not in the twemoji directory.

def image_content(*paths)
  File.read(Rails.root.join("app/assets/images/#{paths.join('/')}")).freeze
end

def twemoji(name)
  image_content("twemoji", "#{name}.svg")
end

reading_icon = twemoji("drawer")
contact_icon = twemoji("contact")
...

I'm sure this achieves the "unlikely to have a typo on only one line" goal of removing duplication while providing little concrete value in added readability.

[juliannatetreault]

Looks good to me! 🚀 Also, TIL what a "twemoji" is. 😄