Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change div to aside tag and add aria-label to contain campaign banner… #15034

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/layouts/application.html.erb
Expand Up @@ -91,15 +91,15 @@
<div id="page-content-inner">
<div id="page-route-change" class="screen-reader-only" aria-live="polite" aria-atomic="true"></div>
<% if @hero_html %>
<div id="hero-html-wrapper" class="overflow-x-hidden" data-name="<%= @hero_area.name %>">
<aside id="hero-html-wrapper" aria-label="Campaign banner" class="overflow-x-hidden" data-name="<%= @hero_area.name %>">
<script>
// Make sure html variant element has id hero-html-wrapper and data-name as its name
if (localStorage.getItem('exited_hero') === '<%= @hero_area.name.html_safe %>') {
document.getElementById('hero-html-wrapper').style.display = 'none';
}
</script>
<%= @hero_html.html_safe %>
</div>
</aside>
<% end %>
<%= yield %>
<div id="runtime-banner-container"></div>
Expand Down