Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin API use case 1: endpoint to create users #16520

Merged
merged 4 commits into from Feb 15, 2022
Merged

Admin API use case 1: endpoint to create users #16520

merged 4 commits into from Feb 15, 2022

Conversation

citizen428
Copy link
Contributor

@citizen428 citizen428 commented Feb 10, 2022 •
edited

What type of PR is this? (check all applicable)

  • Feature

Description

This PR adds an endpoint for admin users to trigger an invitation to the Forem instance.

Related Tickets & Documents

Closes #16426

QA Instructions, Screenshots, Recordings

Nothing specific, the specs should cover it quite well.

UI accessibility concerns?

API onlu

Added/updated tests?

  • Yes

[Forem core team only] How will this change be communicated?

@citizen428 citizen428 requested a review from a team as a code owner February 10, 2022 06:41
@citizen428 citizen428 requested review from a team and maestromac and removed request for a team February 10, 2022 06:41
@citizen428 citizen428 marked this pull request as draft February 10, 2022 06:41
@citizen428 citizen428 removed request for a team and maestromac February 10, 2022 06:41
citizen428
citizen428 commented Feb 10, 2022
View reviewed changes
app/controllers/api/v0/admin/users_controller.rb
@@ -0,0 +1,23 @@
module Api
module V0
module Admin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't insist on keeping the Admin namespace but it made sense to me to indicate that this route requires a token belonging to an admin user.

@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Feb 10, 2022
@citizen428 citizen428 force-pushed the citizen428/api-admin-endpoint-to-create-users-16426 branch from 7e7ae91 to 7519de9 Compare February 10, 2022 08:07
@citizen428 citizen428 changed the title [WIP] Add Api::V0::Admin::UsersController#create Add Api::V0::Admin::UsersController#create Feb 10, 2022
@jeremyf jeremyf self-requested a review February 10, 2022 16:11
@citizen428 citizen428 changed the title Add Api::V0::Admin::UsersController#create Admin API use case 1: endpoint to create users Feb 11, 2022
@citizen428 citizen428 marked this pull request as ready for review February 11, 2022 06:35
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Feb 11, 2022
@citizen428 citizen428 mentioned this pull request Feb 11, 2022
Merged
jeremyf
jeremyf approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@jeremyf jeremyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had previously approved, but realized it was in draft, so I removed that approval.

But it's back! Looks good to me.

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 11, 2022
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Feb 11, 2022
@citizen428 citizen428 merged commit d5ecf61 into main Feb 15, 2022
@citizen428 citizen428 deleted the citizen428/api-admin-endpoint-to-create-users-16426 branch February 15, 2022 02:30
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 15, 2022
headline-design pushed a commit to headline-design/forem-1 that referenced this pull request Mar 11, 2022
@citizen428
Admin API use case 1: endpoint to create users (forem#16520)
ae3c0f3
@jaw6 jaw6 mentioned this pull request Jul 14, 2023
Merged
10 tasks
@jaw6 jaw6 mentioned this pull request Sep 8, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyf jeremyf jeremyf approved these changes

@maestromac maestromac maestromac approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin API use case 1: endpoint to create users
3 participants
@citizen428 @jeremyf @maestromac