Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused articles/_splash.html.erb #17198

Merged

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Apr 9, 2022

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

What type of PR is this? (check all applicable)

  • Refactor

Description

Remove unused template app/views/articles/_splash.html.erb from the beginning.

Related Tickets & Documents

Accidentally found during #17196.

[optional] What gif best describes this PR or how it makes you feel?

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir requested a review from a team April 9, 2022 08:59
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 9, 2022
Copy link
Contributor

@juliannatetreault juliannatetreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Apr 11, 2022
@juliannatetreault juliannatetreault merged commit 8bed053 into forem:main Apr 11, 2022
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 11, 2022
@tnir tnir deleted the tnir/remove-articles-splash-template branch April 11, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orphaned articles/_splash template
3 participants