Replace #to_s(:format) with #to_fs

[tnir]

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

What type of PR is this? (check all applicable)

• Refactor

Description

Replaces TimeWithZone#to_s(:format) with TimeWithZone#to_fs.

Related Tickets & Documents

Rails 7 deprecated TimeWithZone#to_s(:format) in favor of TimeWithZone#to_fs.

• Deprecate to_s(format) in favor of to_formatted_s(format) rails/rails#43772
• Make #to_fs the default replacement for #to_s(:format) rails/rails#44354

DEPRECATION WARNING: TimeWithZone#to_s(:rfc822) is deprecated. Please use TimeWithZone#to_fs(:rfc822) instead. (called from block (4 levels) in _app_views_articles_feed_rss_builder__990977305614084656_3900980 at /home/travis/build/forem/forem/app/views/articles/feed.rss.builder:44)

from https://app.travis-ci.com/github/forem/forem/jobs/566636747

Added/updated tests?

• No, and this is why: no logic changed.

[optional] Are there any post deployment tasks we need to perform?

No.

[github-actions]

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

[djuber]

This change looks exactly like the suggested fix in the deprecation. Thanks!

The xml response being built is used for rss feeds (see https://dev.to/feed for examle), and I don't see any tests around this endpoint (I might not have looked closely enough, but it wasn't in the places I would have expected to find them). We probably want to add a test to confirm whether this is making any changes in behavior.

A minimal spec/requests/articles/articles_feed_spec.rb file covering the response content (not parsing the xml or validating that the rss is readable, only asserting the article is in the feed and the date is formatted the way we expect):

require "rails_helper"

RSpec.describe "ArticlesFeed", type: :request do
  let!(:article) { create(:article) }

  it "returns an rss feed with published article details" do
    get "/feed"

    expect(response.body).to include(article.title)
    expect(response.body).to include("<pubDate>#{article.published_at.to_fs(:rfc822)}</pubDate>")
  end
end

I checked with expecting both of these values in the response body, it showed no difference for me and passed both times (the first does give a deprecation warning)

"<pubDate>#{article.published_at.to_s(:rfc822)}</pubDate>"
"<pubDate>#{article.published_at.to_fs(:rfc822)}</pubDate>"