Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cypress from 8.7.0 to 9.5.4 #17368

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Update cypress from 8.7.0 to 9.5.4 #17368

merged 1 commit into from
Apr 21, 2022

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Apr 20, 2022 •
edited

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

What type of PR is this? (check all applicable)

  • Refactor

Description

Updates cypress from 8.7.0 to 9.5.4 (latest).

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

See logs on CI.

UI accessibility concerns?

n/a

Added/updated tests?

  • No, and this is why: CI suite is updated.

@tnir
Update cypress from 8.7.0 to 9.5.4
bbc73e3 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Apr 20, 2022
@github-actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@tnir tnir marked this pull request as ready for review April 20, 2022 09:17
@tnir tnir requested review from a team, Ridhwana and msarit and removed request for a team April 20, 2022 09:17
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Apr 20, 2022
@tnir
Copy link
Contributor Author

tnir commented Apr 20, 2022

Looping in @jeremyf

@jeremyf jeremyf requested review from aitchiss and djuber April 20, 2022 17:24
@djuber
Copy link
Contributor

djuber commented Apr 20, 2022

I had a look at https://applitools.com/blog/whats-new-cypress-9/ and https://docs.cypress.io/guides/references/changelog#9-0-0 and didn't see anything immediately problematic. I don't believe we're using contains() in a way that expected to check styles/scripts (it's counter to most of the existing e2e test design to look for that type of content).

Tests ran green (which is a good sign), my local testing had issues, but it also does on main with version 8.7.0, I assume it's not related to the major version upgrade.

djuber
djuber approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@djuber djuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This development/test only dependency upgrade, and easy to revert if we need to, no expected risk to production environments.

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 20, 2022
@jeremyf jeremyf merged commit 92030f4 into forem:main Apr 21, 2022
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Apr 21, 2022
@tnir tnir deleted the tnir/cypress-9.x branch April 21, 2022 00:36
@aitchiss
Copy link
Contributor

Great to see this updated! I'm wondering though why we didn't get this update via dependabot 🤔

@tnir
Copy link
Contributor Author

tnir commented Apr 21, 2022

Yes, I wonder why dependabot did not work on creation of this PR 😭

jeremyf added a commit that referenced this pull request Apr 21, 2022
@jeremyf
Merge branch 'main' into jeremyf/project---forem#57
58d2752 
* main:
  Update cypress from 8.7.0 to 9.5.4 (#17368)
  Remove DISABLE_STRING variables after PR#16848 (#17367)
  Busting tag cache when space changes (#17384)
  fix bug in search and filter indicators (#17341)
  Enable string uuid as namespace (#17309)
  Bump @storybook/preact from 6.4.21 to 6.4.22 (#17380)
  toggle fix for spaces (#17343)
  style the orgs, add cypress tests (#17370)
  Bump sass from 1.50.0 to 1.50.1 (#17378)
  Bump babel-loader from 8.2.4 to 8.2.5 (#17355)
  Bump core-js from 3.21.1 to 3.22.1 (#17354)
  Bump lint-staged from 12.3.7 to 12.3.8 (#17377)
  Bump @storybook/addon-backgrounds from 6.4.21 to 6.4.22 (#17369)
  Member index layout tweaks (#17376)
  update chevron left (#17372)
  feat: aria-hidden (#17375)
  Bump @storybook/addon-a11y from 6.4.21 to 6.4.22 (#17334)
  Bump @storybook/addon-storysource from 6.4.21 to 6.4.22 (#17342)
@tnir tnir mentioned this pull request May 12, 2022
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyf jeremyf jeremyf approved these changes

@djuber djuber djuber approved these changes

@Ridhwana Ridhwana Awaiting requested review from Ridhwana

@msarit msarit Awaiting requested review from msarit

@aitchiss aitchiss Awaiting requested review from aitchiss

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tnir @djuber @aitchiss @jeremyf