Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routine Rubopcop lint fixes #17844

Merged
merged 4 commits into from Jun 7, 2022
Merged

Routine Rubopcop lint fixes #17844

merged 4 commits into from Jun 7, 2022

Conversation

maestromac
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor

Description

bundle exec rubocop -A

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Added tests?

  • no, because they aren't needed

Added to documentation?

  • no documentation needed

[optional] Are there any post deployment tasks we need to perform?

n/a

@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Jun 6, 2022
@maestromac maestromac marked this pull request as ready for review June 7, 2022 12:50
@maestromac maestromac requested a review from a team as a code owner June 7, 2022 12:50
@maestromac maestromac requested a review from a team June 7, 2022 12:50
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Jun 7, 2022
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 7, 2022
juliannatetreault
juliannatetreault approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@juliannatetreault juliannatetreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maestromac maestromac merged commit 678dda8 into main Jun 7, 2022
@maestromac maestromac deleted the mac/chore/routine-robocop-a branch June 7, 2022 14:17
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyf jeremyf jeremyf approved these changes

@juliannatetreault juliannatetreault juliannatetreault approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maestromac @jeremyf @juliannatetreault